-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data statistics script for MDN 2019 key result goal #3557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor notes here, apart from the null matching question. Thank you for doing this, @Elchi3!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more questions. Thank you, Florian!
@foolip What do you think about this now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One suggestions for improvement, but nothing that would change the behavior.
}; | ||
|
||
const iterateData = (data) => { | ||
for (let key in data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this will also traverse into strings and arrays, with key
being 0, 1, 2 and so on. processData
will get called with 1-char strings as arguments and do nothing. This is pretty harmless, just something I was bitten by when writing very similar code with different conditions in processData
.
I think this is good enough for now. Thanks everyone! Let's land it. |
Here are the stats at commit fb736a5:
I did some tweaking of the script to see which are was the most incomplete, and it looks like it's api.*, and APIs on Safari on iOS is the browser+bucket category the most incomplete. CSS data isn't too bad overall. |
This adds a script that gathers data for the MDN 2019 key result goal as presented in #3555
Inspired by https://github.com/atopal/browser-compat-data-dashboard